-
-
Notifications
You must be signed in to change notification settings - Fork 4
feat(server): Implement batch endpoint #250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
lcian
wants to merge
31
commits into
lcian/feat/batching-server
Choose a base branch
from
lcian/feat/batching-service
base: lcian/feat/batching-server
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcian
commented
Dec 19, 2025
| } | ||
|
|
||
| #[cfg(test)] | ||
| mod tests { |
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sloppy test generated by Claude.
We will replace this with e2e tests using the clients after we have client implementations of batching.
lcian
commented
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a simple implementation for the batch endpoint that simply loops through the requests in batch and executes them sequentially.
This is already an improvement over having to issue multiple single-object requests, and prepares us to work on the client-side implementation of batching.
The endpoint can be changed later to issue requests in batches to the underling
StorageServiceto make this even more efficient.